Skip to content

Add configurable banner links#39

Merged
saturnflyer merged 3 commits intomainfrom
customizable-links
Mar 11, 2026
Merged

Add configurable banner links#39
saturnflyer merged 3 commits intomainfrom
customizable-links

Conversation

@saturnflyer
Copy link
Member

Summary

  • Adds exception_links, job_links, and warning_links configuration options for clickable banner items
  • Uses simple string path patterns with :id interpolation (e.g., /errors/:id)
  • Includes record IDs in format_for_banner output for ExceptionTrack and SolidErrors adapters

Test plan

  • 24 new specs for configuration, banner link rendering, styling, and XSS safety
  • Updated existing adapter specs for :id inclusion
  • Full suite passes (119 examples, 0 failures)

🤖 Generated with Claude Code

@saturnflyer saturnflyer requested a review from a team as a code owner March 11, 2026 21:32
saturnflyer and others added 2 commits March 11, 2026 17:40
Allow users to configure clickable links in the banner for exceptions,
jobs, and warnings via string path patterns with :id interpolation.

Added: Configurable banner links for exceptions, jobs, and warnings via string path patterns
Version: minor
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ExceptionTrack includes the log record ID. SolidErrors uses the error
record ID (falling back to occurrence ID). Updated base class docs to
reflect the new :id key in the banner data hash.

Added: Record ID in format_for_banner output for linking to individual records
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Contributor

@cseeman cseeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the link-rendering logic in render_exceptions/render_warnings is pretty similar and could probably be extracted into a shared helper, but that is not-blocking.

Deduplicate link-rendering logic between render_exceptions and
render_warnings per PR #39 review feedback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@saturnflyer saturnflyer merged commit d74b0b7 into main Mar 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants